Github user caneGuy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20508#discussion_r166839312
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -327,6 +327,14 @@ object TypeCoercion {
           // Skip nodes who's children have not been resolved yet.
           case e if !e.childrenResolved => e
     
    +      // For integralType should not convert to double which will cause 
precision loss.
    +      case a @ BinaryArithmetic(left @ StringType(), right @ 
IntegralType()) =>
    --- End diff --
    
    @wangyum Sorry for bothering you, i will take some time to fix this later . 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to