Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20527#discussion_r166853858
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala 
---
    @@ -132,6 +134,32 @@ class InMemoryCatalogedDDLSuite extends DDLSuite with 
SharedSQLContext with Befo
           checkAnswer(spark.table("t"), Row(Row("a", 1)) :: Nil)
         }
       }
    +
    +  // TODO: This test is copied from HiveDDLSuite, unify it later.
    +  test("SPARK-23348: append data to data source table with saveAsTable") {
    --- End diff --
    
    Do we also want to cover the following case:
    ```
    2) Target tables have column metadata
    ```?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to