Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20516#discussion_r167159549
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
    @@ -59,6 +59,7 @@ abstract class SparkFunSuite
       protected val enableAutoThreadAudit = true
     
       protected override def beforeAll(): Unit = {
    +    System.setProperty("spark.testing", "true")
    --- End diff --
    
    if we are already doing this, let's make it more explicit that we should 
remove `./project/SparkBuild.scala:795: javaOptions in Test += 
"-Dspark.testing=1"` and set `spark.testing` in `SparkFunSuite.beforeAll`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to