Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20554#discussion_r168625742
  
    --- Diff: 
external/kafka-0-10-sql/src/test/resources/kafka-source-initial-offset-version-2.1.0.bin
 ---
    @@ -1 +1 @@
    -2{"kafka-initial-offset-2-1-0":{"2":0,"1":0,"0":0}}
    \ No newline at end of file
    +2{"kafka-initial-offset-2-1-0":{"2":2,"1":1,"0":0}}
    --- End diff --
    
    I modified the to make the test "deserialization of initial offset written 
by Spark 2.1.0 " stronger. See the updated test. The way it goes now is that we 
start the query from earliest offset, and simultaneous have this initial 
offsets that are NOT at 0 offset. And we check that the query is reading the 
first offset as given in the initial offset and not the earliest available in 
the topic. Hence I am changing the file a little bit, the values not the format.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to