Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168670792
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -521,7 +554,13 @@ case class Signum(child: Expression) extends
UnaryMathExpression(math.signum, "S
case class Sin(child: Expression) extends UnaryMathExpression(math.sin,
"SIN")
@ExpressionDescription(
- usage = "_FUNC_(expr) - Returns the hyperbolic sine of `expr`.",
+ usage = "_FUNC_(expr) - Returns hyperbolic sine of `expr`, " +
--- End diff --
I think we can just do as below:
```scala
...
usage = """
_FUNC_(expr) - Returns hyperbolic sine of `expr`, as if computed by
`java.lang.Math._FUNC_`.
""",
...
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
