Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169291756
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,165 @@ object functions {
//////////////////////////////////////////////////////////////////////////////////////////////
/**
- * Computes the cosine inverse of the given value; the returned angle is
in the range
- * 0.0 through pi.
--- End diff --
Seems like a valid point and I tend to agree with the conclusion to create
a separate Jira for this. So far the discussion was about {{functions.scala}}
but other languages should offer similar descriptions for the same thing.
@srowen, can you please comment on this? I will take {{functions.scala}} out
for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
