Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/20647#discussion_r170185948
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -77,31 +79,32 @@ class MicroBatchExecution(
sparkSession.sqlContext.conf.disabledV2StreamingMicroBatchReaders.split(",")
val _logicalPlan = analyzedPlan.transform {
- case streamingRelation@StreamingRelation(dataSourceV1, sourceName,
output) =>
- toExecutionRelationMap.getOrElseUpdate(streamingRelation, {
+ case s @ StreamingRelation(dsV1, sourceName, output) =>
--- End diff --
If you are touching that specific code then its fine to fix the style, but
in general I tend to agree that it makes the diff harder to read and commit
harder to back port if you include spurious changes.
I've even seen guidelines that specifically prohibit fixing style just to
fix style since it obfuscates the history.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
