Github user Ngone51 commented on the issue:

    https://github.com/apache/spark/pull/20667
  
    Hi, @caneGuy , sorry for my previous comment as I mixed up ```BlockId``` 
with ```BlockManagerId```, and leave some wrong comments. And thanks for your 
reply.
    
    Back to now, I have the same question with @cloud-fan ,
    > Why we need this cache?
    
    though, we have a better cache way(guava cache) now.
    
    My confusions:
    - It is weird  that we need to create a ```BlockManagerId ``` before  we 
get a same one from the cache.
    
    - And on executor side, when ```BlockManagerId ``` registered to master and 
return with an updated ```BlockManagerId ``` , the new ```BlockManagerId ``` 
does not be updated to ```blockManagerIdCache```. So, it seems executor side's 
```BlockManagerId``` has little relevance with ```blockManagerIdCache```.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to