Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r173331220
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -591,7 +591,7 @@ class MetastoreDataSourcesSuite extends QueryTest with
SQLTestUtils with TestHiv
}
test("Pre insert nullability check (ArrayType)") {
- withTable("arrayInParquet") {
+ withTable("array") {
--- End diff --
It would be good, maybe in a future cleanup, to replace all these repeating
string literals (e.g, "array" 7 times, "map" 7 times) with a variable name.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
