GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/20785

    [SPARK-23640][CORE] Fix hadoop config may override spark config

    ## What changes were proposed in this pull request?
    
    It may be get `spark.shuffle.service.port` from 
https://github.com/apache/spark/blob/9745ec3a61c99be59ef6a9d5eebd445e8af65b7a/core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala#L459
    
    Therefore, the client configuration `spark.shuffle.service.port` does not 
working unless the configuration is `spark.hadoop.spark.shuffle.service.port`.
    
    - This configuration is not working:
    ```
    bin/spark-sql --master yarn --conf spark.shuffle.service.port=7338
    ```
    - This configuration work:
    ```
    bin/spark-sql --master yarn --conf 
spark.hadoop.spark.shuffle.service.port=7338
    ```
    
    This PR fix this issue.
    
    ## How was this patch tested?
    
    It's difficult to carry out unit testing. But I've tested it manually.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark SPARK-23640

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20785
    
----
commit 9745ec3a61c99be59ef6a9d5eebd445e8af65b7a
Author: Yuming Wang <yumwang@...>
Date:   2018-03-09T11:05:29Z

    Fix hadoop config may override spark config

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to