Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20790#discussion_r173621260
--- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
@@ -290,7 +290,8 @@ class LongAccumulator extends AccumulatorV2[jl.Long,
jl.Long] {
private var _count = 0L
/**
- * Adds v to the accumulator, i.e. increment sum by v and count by 1.
+ * Returns false if this accumulator has had any values added to it or
the sum is non-zero.
+ *
--- End diff --
I think this duplicates the doc from `AccumulatorV2.isZero`. Can we simply
remove this wrong doc and revert other changes so that we can reuse inherited
doc from `AccumulatorV2.isZero` in all places?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
