Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20851#discussion_r175651639
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -72,6 +82,14 @@ private[parquet] object ParquetFilters {
           (n: String, v: Any) => FilterApi.notEq(
             binaryColumn(n),
             Option(v).map(b => 
Binary.fromReusedByteArray(v.asInstanceOf[Array[Byte]])).orNull)
    +    case DateType if SQLConf.get.parquetFilterPushDownDate =>
    +      (n: String, v: Any) => {
    --- End diff --
    
    nit:
    
    ```
    (n: String, v: Any) => FilterApi.notEq(
     intColumn(n),
     Option(v).map { d =>
       
DateTimeUtils.fromJavaDate(d.asInstanceOf[java.sql.Date]).asInstanceOf[Integer]
     }.orNull)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to