Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20745#discussion_r175978136
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
---
@@ -405,4 +406,53 @@ class FileStreamSinkSuite extends StreamTest {
}
}
}
+
+ test("SPARK-23288 writing and checking output metrics") {
+ Seq("parquet", "orc", "text", "json").foreach { format =>
+ val inputData = MemoryStream[String]
+ val df = inputData.toDF()
+
+ val outputDir = Utils.createTempDir(namePrefix =
"stream.output").getCanonicalPath
--- End diff --
we should use `withTempDir` to clean up the temp directory at the end
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
