Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20831#discussion_r175980451
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
 ---
    @@ -68,6 +69,15 @@ case class InMemoryRelation(
     
       override protected def innerChildren: Seq[SparkPlan] = Seq(child)
     
    +  override def doCanonicalize(): logical.LogicalPlan =
    +    copy(output = output.map(QueryPlan.normalizeExprId(_, child.output)),
    +      storageLevel = StorageLevel.NONE,
    --- End diff --
    
    It is followed. I just ignored `useCompression`, `batchSize` as they are 
just primitives and don't need to be canonicalized here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to