Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r176841337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -408,6 +408,7 @@ object FunctionRegistry {
expression[MapValues]("map_values"),
expression[Size]("size"),
expression[SortArray]("sort_array"),
+ expression[ConcatArrays]("concat_arrays"),
--- End diff --
Ok, will merge the functions into one. Do you find having one expression
class concatenation per the concatenation type ok?
I'm afraid if I incorporate all the logic into one expression class then
the code will become messy since each codeGen and eveluation has a different
nature.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
