Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176906868
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class HiveDelegationTokenProvider
s"$principal at $metastoreUri")
doAsRealUser {
- val hive = Hive.get(conf, classOf[HiveConf])
--- End diff --
1. This
[`Hive.get()`](https://github.com/apache/spark/blob/v2.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L239)
is different from others, It loaded by `IsolatedClientLoader`.
2. I can not start a `HiveThriftServer2` in a kerberized cluster, so I'm
not sure `CLIService.java` should be updated, How about update it later?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
