Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/20893#discussion_r177577783
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend {
override def close(): Unit = {
try {
+ _isConnected = false
super.close()
} finally {
onDisconnected()
--- End diff --
Yeah, your right, it doesn't look like `onDisconnected` is being used
anywhere, but its marked as `protected` so I guess its meant to be used by a
sub-class (although no sub-class uses it).
So agree, this change should be safe, it doesn't change the semantics of
any use of `onDisconnected`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
