Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20964#discussion_r178784391
--- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NGramSuite.scala
---
@@ -84,7 +84,7 @@ class NGramSuite extends MLTest with DefaultReadWriteTest
{
def testNGram(t: NGram, dataFrame: DataFrame): Unit = {
testTransformer[(Seq[String], Seq[String])](dataFrame, t, "nGrams",
"wantedNGrams") {
- case Row(actualNGrams : Seq[String], wantedNGrams: Seq[String]) =>
+ case Row(actualNGrams : Seq[_], wantedNGrams: Seq[_]) =>
--- End diff --
Just curious, why change `Seq[String]` to `Seq[_]`, is it for fixing some
potential issue ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
