Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20904#discussion_r181015525
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -81,32 +81,37 @@ object KolmogorovSmirnovTest {
* Java-friendly version of `test(dataset: DataFrame, sampleCol: String,
cdf: Double => Double)`
*/
@Since("2.4.0")
- def test(dataset: DataFrame, sampleCol: String,
- cdf: Function[java.lang.Double, java.lang.Double]): DataFrame = {
- val f: Double => Double = x => cdf.call(x)
- test(dataset, sampleCol, f)
+ def test(
+ dataset: Dataset[_],
+ sampleCol: String,
+ cdf: Function[java.lang.Double, java.lang.Double]): DataFrame = {
+ test(dataset, sampleCol, (x: Double) => cdf.call(x))
--- End diff --
ah.... it's my fault. Sorry!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
