GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/21077

    [SPARK-21033][CORE][FOLLOW-UP] Update Spillable

    ## What changes were proposed in this pull request?
    
    Update 
    ```scala
    
SparkEnv.get.conf.getLong("spark.shuffle.spill.numElementsForceSpillThreshold", 
Long.MaxValue)
    ```  
    to 
    ```scala
    SparkEnv.get.conf.get(SHUFFLE_SPILL_NUM_ELEMENTS_FORCE_SPILL_THRESHOLD)
    ```
    
     because of `SHUFFLE_SPILL_NUM_ELEMENTS_FORCE_SPILL_THRESHOLD`'s default 
value is `Integer.MAX_VALUE`:
    
https://github.com/apache/spark/blob/c99fc9ad9b600095baba003053dbf84304ca392b/core/src/main/scala/org/apache/spark/internal/config/package.scala#L503-L511
    
    ## How was this patch tested?
    
    N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark SPARK-21033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21077
    
----
commit a7de7c6d29508cfdcc9c7cb66fa1648c6b4bbbbb
Author: Yuming Wang <yumwang@...>
Date:   2018-04-16T08:12:53Z

    
SparkEnv.get.conf.getLong("spark.shuffle.spill.numElementsForceSpillThreshold", 
Long.MaxValue) -> 
SparkEnv.get.conf.get(SHUFFLE_SPILL_NUM_ELEMENTS_FORCE_SPILL_THRESHOLD)

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to