Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20930#discussion_r182299503
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
    @@ -2399,6 +2399,50 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
         }
       }
     
    +  /**
    +   * This tests the case where origin task success after speculative task 
got FetchFailed
    +   * before.
    +   */
    +  test("[SPARK-23811] FetchFailed comes before Success of same task will 
cause child stage" +
    +    " never succeed") {
    --- End diff --
    
    nit: the test name should describe the expected behavior not the wrong one.
    `SPARK-23811: staged failed by FetchFailed should ignore following 
successful tasks`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to