Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/21169#discussion_r184565093
--- Diff: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ---
@@ -27,3 +27,8 @@ select current_date = current_date(), current_timestamp =
current_timestamp(), a
select a, b from ttf2 order by a, current_date;
select weekday('2007-02-03'), weekday('2009-07-30'),
weekday('2017-05-27'), weekday(null), weekday('1582-10-15 13:10:15');
+
--- End diff --
Does it matter if there are no success cases for from_utc_timestamp and
to_utc_timestamp in here (that is, cases that don't return null)?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
