Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/21165
  
    I do agree task killed event should carry metrics update, as it's 
reasonable to count killed tasks for something like how many bytes were read 
from files.
    
    However, I don't agree user side accumulators should get updates from 
killed tasks, that changes the semantic of accumulators. And I don't think 
end-users need to care about killed tasks.
    
    I haven't read the PR yet, but please make sure this patch only touches 
internal accumulators that are used for metrics reporting.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to