Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21175#discussion_r184596199
--- Diff:
core/src/test/scala/org/apache/spark/io/ChunkedByteBufferSuite.scala ---
@@ -56,6 +56,12 @@ class ChunkedByteBufferSuite extends SparkFunSuite {
assert(chunkedByteBuffer.getChunks().head.position() === 0)
}
+ test("writeFully() can write buffer which is larger than
bufferWriteChunkSize correctly") {
+ val chunkedByteBuffer = new
ChunkedByteBuffer(Array(ByteBuffer.allocate(80*1024*1024)))
+ chunkedByteBuffer.writeFully(new
ByteArrayWritableChannel(chunkedByteBuffer.size.toInt))
+ assert(chunkedByteBuffer.getChunks().head.position() === 0)
--- End diff --
This assert is unnecessary for this PR change. Please replace it with
assert channel's length here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
