Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21153#discussion_r184693307
  
    --- Diff: python/pyspark/ml/util.py ---
    @@ -417,15 +419,24 @@ def _get_metadata_to_save(instance, sc, 
extraMetadata=None, paramMap=None):
             """
             uid = instance.uid
             cls = instance.__module__ + '.' + instance.__class__.__name__
    -        params = instance.extractParamMap()
    +
    +        # User-supplied param values
    +        params = instance._paramMap
             jsonParams = {}
             if paramMap is not None:
                 jsonParams = paramMap
             else:
                 for p in params:
                     jsonParams[p.name] = params[p]
    --- End diff --
    
    `_paramMap`'s keys are `Param` not string.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to