Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21095#discussion_r185980514
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -109,7 +109,15 @@ private[spark] class BasicDriverFeatureStep(
.addToImagePullSecrets(conf.imagePullSecrets(): _*)
.endSpec()
.build()
- SparkPod(driverPod, driverContainer)
+
+ val (driverPodWithVolumes, driverContainerVolumes) =
--- End diff --
Instead of putting the logic of volume mounting in `BasicDriverFeatureStep`
and `BasicExecutorFeatureStep`, we should add a new step for mounting volumes,
similarly to how we handle secrets, e.g., `MountVolumesFeatureStep` where the
logic of `addVolumes` should be. This feature step can be used for both the
driver and executors.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
