Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21235#discussion_r186606160 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -339,9 +339,16 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) { } } - private def assertNotBucketed(operation: String): Unit = { - if (numBuckets.isDefined || sortColumnNames.isDefined) { - throw new AnalysisException(s"'$operation' does not support bucketing right now") --- End diff -- how about minimizing the code changes ``` private def assertNotBucketed(operation: String): Unit = { if (getBucketSpec.isDefined) { throw new AnalysisException(s"'$operation' does not support bucketing right now") } } ```
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org