Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21255#discussion_r186612820
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -1739,6 +1748,13 @@ test_that("string operators", {
         collect(select(df5, repeat_string(df5$a, -1)))[1, 1],
         ""
       )
    +
    +  l6 <- list(list(a = "abc"))
    +  df6 <- createDataFrame(l6)
    +  expect_equal(
    +    collect(select(df6, reverse(df6$a)))[1, 1],
    +    "cba"
    +  )
    --- End diff --
    
    Let's make this inlined while we are here. I would also put this test 
around 1505L above.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to