Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21295#discussion_r187778648
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
 ---
    @@ -879,6 +879,18 @@ class ParquetQuerySuite extends QueryTest with 
ParquetTest with SharedSQLContext
           }
         }
       }
    +
    +  test("SPARK-24230: filter row group using dictionary") {
    +    withSQLConf(("parquet.filter.dictionary.enabled", "true")) {
    --- End diff --
    
    Is this a valid way to control this configuration? It seems to pass with 
`false`, too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to