GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/21327
[SPARK-24107][CORE][followup] ChunkedByteBuffer.writeFully method has not
reset the limit value
## What changes were proposed in this pull request?
According to the discussion in https://github.com/apache/spark/pull/21175 ,
this PR proposes 2 improvements:
1. add comments to explain why we call `limit` to write out `ByteBuffer`
with slices.
2. remove the `try ... finally`
## How was this patch tested?
existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark minor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21327
----
commit cd2f0e3658964818b076e6de150f15db32f3c455
Author: Wenchen Fan <wenchen@...>
Date: 2018-05-15T04:29:56Z
improve
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
