Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21114#discussion_r188164036
--- Diff: core/src/test/scala/org/apache/spark/AccumulatorSuite.scala ---
@@ -237,6 +236,65 @@ class AccumulatorSuite extends SparkFunSuite with
Matchers with LocalSparkContex
acc.merge("kindness")
assert(acc.value === "kindness")
}
+
+ test("updating garbage collected accumulators") {
--- End diff --
tests also have a maintenance cost. Sometimes we change something and break
the test, we need to look into the test and see if the test is wrong or the
change is wrong. Or sometimes the test becomes flaky and we need to investigate.
This test seems to prove a thing can happen while it's already proved by
other tests, and I think this test is not worth the maintenance cost given its
complexity.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
