Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21383#discussion_r190453705
  
    --- Diff: python/pyspark/rdd.py ---
    @@ -791,9 +792,11 @@ def foreach(self, f):
             >>> def f(x): print(x)
             >>> sc.parallelize([1, 2, 3, 4, 5]).foreach(f)
             """
    +        safe_f = fail_on_StopIteration(f)
    --- End diff --
    
    Im okay with `safe` as is too if you feel strongly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to