Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r190491050
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
---
@@ -879,6 +879,15 @@ class ParquetQuerySuite extends QueryTest with
ParquetTest with SharedSQLContext
}
}
}
+
+ test("select function over nested data") {
--- End diff --
I did some forensics to understand the origin and reason for this test. It
was part of the first commit of my original PR almost two years ago. Even then,
this test passes without the rest of the commit. So I can't say why I added
this test except perhaps that I felt it was useful code coverage.
In any case, if you don't think it's a valuable contribution in this PR I'd
rather just remove it entirely.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
