Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21426#discussion_r190761869
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -372,8 +376,27 @@ private[spark] class SparkSubmit extends Logging {
localJars = Option(args.jars).map {
downloadFileList(_, targetDir, sparkConf, hadoopConf, secMgr)
}.orNull
- localPyFiles = Option(args.pyFiles).map {
- downloadFileList(_, targetDir, sparkConf, hadoopConf, secMgr)
+ localPyFiles = Option(args.pyFiles).map { pyFiles =>
+ if (isClientPythonSubmit) {
--- End diff --
Couldn't this logic be in `PythonRunner`? That's basically what SparkSubmit
runs when the conditions you use to create `isClientPythonSubmit` are met.
This class is already pretty hard to navigate, it'd be better to avoid
adding more special cases to it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
