Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21410#discussion_r190790254
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
 ---
    @@ -309,6 +322,9 @@ object CatalystTypeConverters {
             case d: JavaBigDecimal => Decimal(d)
             case d: JavaBigInteger => Decimal(d)
             case d: Decimal => d
    +        case other => throw new IllegalArgumentException(
    +          s"The value (${other.toString}) of the type 
(${other.getClass.getCanonicalName}) "
    +            + s"cannot be converted to ${dataType.simpleString}")
    --- End diff --
    
    Let us use `catalogString` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to