Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/21383#discussion_r191621339 --- Diff: python/pyspark/util.py --- @@ -55,7 +55,9 @@ def _get_argspec(f): """ # `getargspec` is deprecated since python3.0 (incompatible with function annotations). # See SPARK-23569. - if sys.version_info[0] < 3: + if hasattr(f, '_argspec'): --- End diff -- Can you add a comment explaining this? Just from this function it's not clear to me why do we need `_argspec`
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org