Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21454#discussion_r191626037
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
    @@ -25,14 +25,16 @@ import scala.language.postfixOps
     import scala.util.{Random, Try}
     
     import com.esotericsoftware.kryo.Kryo
    +import org.scalatest.Matchers
     
     import org.apache.spark.deploy.history.config._
     import org.apache.spark.internal.config._
     import org.apache.spark.network.util.ByteUnit
     import org.apache.spark.serializer.{JavaSerializer, KryoRegistrator, 
KryoSerializer}
     import org.apache.spark.util.{ResetSystemProperties, RpcUtils}
     
    -class SparkConfSuite extends SparkFunSuite with LocalSparkContext with 
ResetSystemProperties {
    +class SparkConfSuite extends SparkFunSuite with LocalSparkContext with 
ResetSystemProperties with
    +  Matchers {
    --- End diff --
    
    I would do `with Matchers` here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to