Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21428#discussion_r191629554
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/shuffle/ContinuousShuffleSuite.scala
---
@@ -58,39 +46,29 @@ class ContinuousShuffleReadSuite extends StreamTest {
super.afterEach()
}
- test("receiver stopped with row last") {
- val rdd = new ContinuousShuffleReadRDD(sparkContext, numPartitions = 1)
- val endpoint =
rdd.partitions(0).asInstanceOf[ContinuousShuffleReadPartition].endpoint
- send(
- endpoint,
- ReceiverEpochMarker(0),
- ReceiverRow(0, unsafeRow(111))
- )
+ private implicit def unsafeRow(value: Int) = {
--- End diff --
And where it leverages the `implicit` attribute of this method? I'm not
sure it is really needed, but I'm review on Github page so I might be missing
here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
