Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21448
`abs` does seem to belong with math functions.
`isnan` and `nanvl` are sort of math related but to me feel more like
`isnull`. It's more about testing representations of a value, not math on them
(NaN isn't a mathematical notion, note). I'd leave it. Those methods in the JDK
aren't in java.lang.Math, FWIW.
`bitwiseNOT` sure seems like an odd man out. The other bitwise functions
are defined in `Column.scala` I don't see why, other than that 'not' is a unary
operator. This came from
https://github.com/apache/spark/pull/5867#discussion-diff-29559385 but looks
like that was a comment about `functions.py`. Although its location is odd, I
guess I'd leave it unless @Shiti or @rxin say it's OK to move.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
