Github user galv commented on a diff in the pull request:
https://github.com/apache/spark/pull/21511#discussion_r193945389
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -172,7 +184,7 @@ private[spark] class BasicExecutorFeatureStep(
.addToImagePullSecrets(kubernetesConf.imagePullSecrets(): _*)
.endSpec()
.build()
- SparkPod(executorPod, containerWithLimitCores)
+ SparkPod(executorPod, containerWithLimitGpus)
--- End diff --
What if you want to request both GPU's and another resource (e.g., FPGA's)
for your executors? You'd have to hard-code chain another optional map like you
did in the pull requests. Your current code does not pave a good path forward
to requesting other types of resources.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
