Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21547#discussion_r194950951
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
    @@ -359,6 +359,41 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
         }
       }
     
    +  test("filter pushdown - decimal(ByteArrayDecimalType)") {
    +    val one = new java.math.BigDecimal(1)
    +    val two = new java.math.BigDecimal(2)
    +    val three = new java.math.BigDecimal(3)
    +    val four = new java.math.BigDecimal(4)
    --- End diff --
    
    Hm, why don't we follow the style in this file with `implicit class`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to