Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21560#discussion_r197000483
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
 ---
    @@ -349,6 +349,17 @@ object UnsupportedOperationChecker {
                   _: DeserializeToObject | _: SerializeFromObject | _: 
SubqueryAlias |
                   _: TypedFilter) =>
             case node if node.nodeName == "StreamingRelationV2" =>
    +        case Repartition(1, false, _) =>
    +        case node: Aggregate =>
    +          val aboveSinglePartitionCoalesce = node.find {
    +            case Repartition(1, false, _) => true
    --- End diff --
    
    What if we have multiple repartitions which one meets the case and others 
are not? I'm not sure we are restricting repartition operations to be only once.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to