Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21590#discussion_r197620496
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
 ---
    @@ -58,6 +58,10 @@ class JdbcRelationProvider extends 
CreatableRelationProvider
           parameters: Map[String, String],
           df: DataFrame): BaseRelation = {
         val options = new JDBCOptions(parameters)
    +    require(
    +      options.tableName.isDefined,
    +      s"Option '${JDBCOptions.JDBC_TABLE_NAME}' is required. " +
    +        s"Option '${JDBCOptions.JDBC_QUERY_STRING}' is not applicable 
while writing.")
    --- End diff --
    
    Let us create a `JDBCOptionsInWrite`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to