Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21631#discussion_r197887650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
---
@@ -183,11 +183,19 @@ class UnivocityParser(
}
}
+ private lazy val doParse = if (schema.nonEmpty) {
--- End diff --
Do you really need lazy here. In most cases, time interval between calling
of the constructor and the parse() method is pretty short. I don't think we win
something here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
