Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21575#discussion_r198579275
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -74,17 +75,17 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, clock: Clock)
// "spark.network.timeout" uses "seconds", while
`spark.storage.blockManagerSlaveTimeoutMs` uses
// "milliseconds"
- private val slaveTimeoutMs =
- sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs", "120s")
private val executorTimeoutMs =
- sc.conf.getTimeAsSeconds("spark.network.timeout",
s"${slaveTimeoutMs}ms") * 1000
+ sc.conf.getTimeAsSeconds("spark.network.timeout",
+ s"${sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs",
+ "120s")}ms").seconds.toMillis
// "spark.network.timeoutInterval" uses "seconds", while
// "spark.storage.blockManagerTimeoutIntervalMs" uses "milliseconds"
- private val timeoutIntervalMs =
- sc.conf.getTimeAsMs("spark.storage.blockManagerTimeoutIntervalMs",
"60s")
private val checkTimeoutIntervalMs =
- sc.conf.getTimeAsSeconds("spark.network.timeoutInterval",
s"${timeoutIntervalMs}ms") * 1000
+ sc.conf.getTimeAsSeconds("spark.network.timeoutInterval",
--- End diff --
please revert this since it's unrelated.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
