Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r198722458
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3905,6 +3905,18 @@ setMethod("rollup",
groupedData(sgd)
})
+isTypeAllowed <- function(x) {
--- End diff --
or define this inline instead- this is simple enough
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
