Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21650#discussion_r199021120
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
 ---
    @@ -166,8 +190,9 @@ object ExtractPythonUDFs extends Rule[SparkPlan] with 
PredicateHelper {
                   ArrowEvalPythonExec(vectorizedUdfs, child.output ++ 
resultAttrs, child)
                 case (vectorizedUdfs, plainUdfs) if vectorizedUdfs.isEmpty =>
                   BatchEvalPythonExec(plainUdfs, child.output ++ resultAttrs, 
child)
    -            case _ =>
    -              throw new IllegalArgumentException("Can not mix vectorized 
and non-vectorized UDFs")
    +            case (vectorizedUdfs, plainUdfs) =>
    +              throw new AnalysisException(
    --- End diff --
    
    Why change the exception type?  Can you make a test that causes this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to