Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21623#discussion_r199043411
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
    @@ -660,6 +661,56 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
           assert(df.where("col > 0").count() === 2)
         }
       }
    +
    +  test("filter pushdown - StringStartsWith") {
    +    withParquetDataFrame((1 to 4).map(i => Tuple1(i + "str" + i))) { 
implicit df =>
    --- End diff --
    
    Added `testStringStartsWith` to test that exactly go through the `canDrop` 
and `inverseCanDrop`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to