Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21462#discussion_r199307562
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
 ---
    @@ -46,8 +46,6 @@ private[spark] class KubernetesClusterManager extends 
ExternalClusterManager wit
           sc: SparkContext,
           masterURL: String,
           scheduler: TaskScheduler): SchedulerBackend = {
    -    val executorSecretNamesToMountPaths = 
KubernetesUtils.parsePrefixedKeyValuePairs(
    -      sc.conf, KUBERNETES_EXECUTOR_SECRETS_PREFIX)
    --- End diff --
    
    @mccheah I think the logic has changed otherwise the tests I have in this 
PR(https://github.com/apache/spark/pull/21652)  would have failed when removed 
that part and re-run them.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to