Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21666#discussion_r199313370
  
    --- Diff: R/pkg/R/client.R ---
    @@ -61,6 +61,11 @@ generateSparkSubmitArgs <- function(args, sparkHome, 
jars, sparkSubmitOpts, pack
     }
     
     checkJavaVersion <- function() {
    +  if (is_windows()) {
    +    # See SPARK-24535
    --- End diff --
    
    it would - I guess we need to root cause the reason why checkJavaVersion() 
fails on Windows/jdk 8 - otherwise sparkR.session() would just fail and no way 
to continue.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to